[ https://issues.apache.org/jira/browse/HDDS-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706631#comment-16706631 ]
Yiqun Lin commented on HDDS-848: -------------------------------- The patch almost looks good, [~bharatviswa]. Some minor comments: *StorageContainerManager.java* Can we add the tag of {{@Override}} for {{getContainerStateCount}}? *TestSCMMXBean.java* Line144, Line150: Can we format these lines? Looks like missing some white spaces. Line138,Line166: Can we add an additional check for expected container state from the map key before we do {{verifyEquals}} function? BTW, fix checkstyle issues. > Create SCM metrics related to container state > --------------------------------------------- > > Key: HDDS-848 > URL: https://issues.apache.org/jira/browse/HDDS-848 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Bharat Viswanadham > Assignee: Bharat Viswanadham > Priority: Major > Attachments: HDDS-848.00.patch, HDDS-848.01.patch > > > 1.Number of containers (open, closing, closed) > And also see if any other metrics can be added which will be useful. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org