[ https://issues.apache.org/jira/browse/HDDS-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707714#comment-16707714 ]
Bharat Viswanadham edited comment on HDDS-864 at 12/3/18 7:56 PM: ------------------------------------------------------------------ Hi [~elek] Thanks for the contribution. Few comments I have: # Unused imports in Codec.java # Javadoc is missing for add() in CodecRegistry. # We have not converted getS3Table()is this intentional change? # Can we move all the codec implementations to codec package? # Unused import in OmBucketCodecInfo.java. # OmKeyInfo.java, the constructor is changed to public, I think we don’t need it. # Can we add @VisibleForTesting notion on the constructor not taking codecRegistry param? # Add null checks in toPersistedFormat and fromPersistedFormat. As sometimes these can be null, and throw NPE. (This is the cause for so many test failures) # Fix Jenkins check style issues and test failures. I think test failures are related to this patch. was (Author: bharatviswa): Hi [~elek] Thanks for the contribution. Few comments I have: # Unused imports in Codec.java # Javadoc is missing for add() in CodecRegistry. # We have not converted getS3Table()is this intentional change? # Can we move all the codec implementations to codec package? # Unused import in OmBucketCodecInfo.java. # OmKeyInfo.java, the constructor is changed to public, I think we don’t need it. # Can we add @VisibleForTesting notion on the constructor not taking codecRegistry param? # Add null checks in toPersistedFormat and fromPersistedFormat. As sometimes these can be null, and throw NPE. (This is the cause for so many test failures) > Use strongly typed codec implementations for the tables of the > OmMetadataManager > -------------------------------------------------------------------------------- > > Key: HDDS-864 > URL: https://issues.apache.org/jira/browse/HDDS-864 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: OM > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Attachments: HDDS-864.001.patch, HDDS-864.002.patch > > > HDDS-748 provides a way to use higher level, strongly typed metadata Tables, > such as Table<String,OmKeyInfo> instead of Table<byte[],byte[]> > HDDS-748 provides the new TypedTable in this jira I would fix the > OmMetadataManagerImpl to use the type-safe tables instead of the raw ones. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org