[
https://issues.apache.org/jira/browse/HDDS-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713746#comment-16713746
]
Xiaoyu Yao commented on HDDS-99:
--------------------------------
Thanks [~dineshchitlangia] for the patch. It looks good to me overall. Just
have two comments:
SCMBlockProtocolServer.java
Line 159-161: can we avoid building the auditMap outside logWritexxx(), this
might need refactoring of the AUDIT class that wen can handle it in a follow up
JIRA.
Line 162: auditSuccess variable can be removed if we remove the finally and
move the logic out of finally{}. This applies to some other places too.
> Adding SCM Audit log
> --------------------
>
> Key: HDDS-99
> URL: https://issues.apache.org/jira/browse/HDDS-99
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: SCM
> Reporter: Xiaoyu Yao
> Assignee: Dinesh Chitlangia
> Priority: Major
> Labels: alpha2
> Attachments: HDDS-99.001.patch, HDDS-99.002.patch
>
>
> This ticket is opened to add SCM audit log.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
