[
https://issues.apache.org/jira/browse/HDDS-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724527#comment-16724527
]
Dinesh Chitlangia commented on HDDS-393:
----------------------------------------
[~bharatviswa] thanks for reviewing the patch.
Regarding the comments #1 & #2, I suggest we file a follow up improvement jira
which will address these review comments in addition to support for loading a
directory containing multiple log files, support for compressed log files etc.
{quote}Test cases, the loadDB should be done in BeforeClass, as this is
required for all other tests. If i execute tests single, I am getting an
error.{quote}
Yes, if you run individual test it will fail. The idea was to run the test
class so it would guarantee the execution in the right order. Hence the test
class has been annotated as follows:
{{@FixMethodOrder(MethodSorters.NAME_ASCENDING)}}
Let me know if you would still like me to move it.
{quote}Can we add a test case for top5ActiveTime, is this query will tell in
that specific time, how many operations happened? (But this (Date
format:2018-09-06 01:57:22,996) considers including second, as the query
considers substring from start till ",") Is this the intention of this query
template? (So, with this we can know in an instant how many operations have
done, from that we take top 5){quote}
By definition top5ActiveTime lists Top 5 active times, grouped by seconds.
Thus, we are trying to do a substr operation to fetch values as needed.
So, now the question is - would you like me to modify and just fetch the list
grouped by milliseconds or retain the current template?
We can add the test case, in this patch or in the follow up jira.
Let me know your thoughts.
> Audit Parser tool for processing ozone audit logs
> -------------------------------------------------
>
> Key: HDDS-393
> URL: https://issues.apache.org/jira/browse/HDDS-393
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Labels: alpha2
> Attachments: HDDS-393.001.patch, HDDS-393.002.patch,
> HDDS-393.003.patch
>
>
> Jira to create audit parser tool to process ozone audit logs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
