[ https://issues.apache.org/jira/browse/HDDS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725271#comment-16725271 ]
Xiaoyu Yao edited comment on HDDS-102 at 12/19/18 6:55 PM: ----------------------------------------------------------- Thanks [~anu] for the update. Patch v4 LGTM. I just have few minor comments, +1 after that being fixed. CertificateSignRequest.java Line 105: StringWriter#close() is no-op, so we could using the following instead. {code:java} StringWriter str=new StringWriter(); try (JcaPEMWriterpemWriter= new JcaPEMWriter(str)){ pemWriter.writeObject(pemObject); } return str.toString(); {code} MockApprover.java Line 23/33: unused imports TestDefaultProfile.java Line 56-57/61: unused imports was (Author: xyao): Thanks [~anu] for the update. Patch v4 LGTM. I just have few minor comments, +1 after that being fixed. CertificateSignRequest.java Line 105: StringWriter#close() is no-op, so we could using the following instead. {code} StringWriter str=*new* StringWriter(); *try* (JcaPEMWriterpemWriter=*new*JcaPEMWriter(str)){ pemWriter.writeObject(pemObject); } *return* str.toString(); {code} MockApprover.java Line 23/33: unused imports TestDefaultProfile.java Line 56-57/61: unused imports > SCM CA: SCM CA server signs certificate for approved CSR > -------------------------------------------------------- > > Key: HDDS-102 > URL: https://issues.apache.org/jira/browse/HDDS-102 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Xiaoyu Yao > Assignee: Anu Engineer > Priority: Major > Attachments: HDDS-102-HDDS-4.001.patch, HDDS-102-HDDS-4.001.patch, > HDDS-102-HDDS-4.002.patch, HDDS-102-HDDS-4.003.patch, > HDDS-102-HDDS-4.004.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org