[
https://issues.apache.org/jira/browse/HDFS-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728523#comment-16728523
]
Konstantin Shvachko commented on HDFS-14130:
--------------------------------------------
Hi [~xiangheng]. Sounds like your patch is the right direction. This should
prevent from converting an Observer into Standby.
# Although I would prefer to verify {{OBSERVER}} state inside
{{ZKFailoverController.verifyChangedServiceState()}}, which seems a more direct
place related to this logic.
# It would be good to add a unit test with ZKFC and Observer to reproduce this
condition.
# Do I understand correctly that with your patch Observer will still be
considered as a target for failover? Thought may be adding Observer state check
into {{checkEligibleForFailover()}} could solve that.
> Make ZKFC ObserverNode aware
> ----------------------------
>
> Key: HDFS-14130
> URL: https://issues.apache.org/jira/browse/HDFS-14130
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HDFS-12943
> Reporter: Konstantin Shvachko
> Assignee: xiangheng
> Priority: Major
> Attachments: HDFS-14130-HDFS-12943.001.patch
>
>
> Need to fix automatic failover with ZKFC. Currently it does not know about
> ObserverNodes trying to convert them to SBNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
