[
https://issues.apache.org/jira/browse/HDFS-14182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731198#comment-16731198
]
Dinesh Chitlangia commented on HDFS-14182:
------------------------------------------
[~fengchuang] - Thank you for adding this improvement. Overall the patch LGTM.
+1 (non binding).
Minor suggestion:
You could avoid creating the local infoAddr variable as it is not being used
except in the following line.
{code:java}
if (index > x0 && index <= x1) {
var infoAddr = dn.infoAddr;
ips.push(infoAddr.split(":")[0]);
}
{code}
You could do something like:
{code:java}
if (index > x0 && index <= x1) {
ips.push(dn.infoAddr.split(":")[0]);
}
{code}
> Datanode usage histogram is clicked to show ip list
> ---------------------------------------------------
>
> Key: HDFS-14182
> URL: https://issues.apache.org/jira/browse/HDFS-14182
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: fengchuang
> Priority: Major
> Attachments: HDFS-14182.001.patch, showip.jpeg
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
