[ https://issues.apache.org/jira/browse/HDFS-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101263#comment-13101263 ]
Todd Lipcon commented on HDFS-1197: ----------------------------------- Hi Sanjay. I'm not sure I follow your reasoning here. This patch doesn't ignore blockReceived when it beats the completeFile call in the usual case. If the blockReceived call is for the correct generation stamp, it is added to the DN usual. It only changes behavior when an old generation stamp is reported. > Blocks are considered "complete" prematurely after commitBlockSynchronization > or DN restart > ------------------------------------------------------------------------------------------- > > Key: HDFS-1197 > URL: https://issues.apache.org/jira/browse/HDFS-1197 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, hdfs client, name-node > Affects Versions: 0.20-append > Reporter: Todd Lipcon > Fix For: 0.20-append > > Attachments: HDFS-1197-without-addStoredBlock-change.1.patch, > hdfs-1197-test-changes.txt, hdfs-1197.txt, testTC2-failure.txt > > > I saw this failure once on my internal Hudson job that runs the append tests > 48 times a day: > junit.framework.AssertionFailedError: expected:<114688> but was:<98304> > at org.apache.hadoop.hdfs.AppendTestUtil.check(AppendTestUtil.java:112) > at > org.apache.hadoop.hdfs.TestFileAppend3.testTC2(TestFileAppend3.java:116) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira