[ https://issues.apache.org/jira/browse/HDDS-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733509#comment-16733509 ]
Anu Engineer commented on HDDS-955: ----------------------------------- {quote}TestCertificateCodec: Unintended change? {quote} Thanks fixed. {quote}L382: rename initializeCertificateServer to createCertificateServer or instantiateCertificateServer ? {quote} I see that the comments for this function is misleading, fixed that. Thanks for flagging that. {quote}Add test case for change in SCM initialization in TestStorageContainerManager? {quote} Three of the test failures from the earlier patch was due to failure in the patch. So this code path is getting tested via the current SCM tests. I will also add more tests when we expose the APIs later. {quote}Seems in this patch we just want to hook default CA to SCM. Will we expose some of the API's for SCM CA in separate patch ? (Clients will call those api's via rpc) {quote} Yes, You are correct. The idea is to add this code for now and then expose the functions in the next few patches. I have uploaded patch v2 that addresses all these issues. > SCM CA: Add CA to SCM. > ---------------------- > > Key: HDDS-955 > URL: https://issues.apache.org/jira/browse/HDDS-955 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: SCM > Reporter: Anu Engineer > Assignee: Anu Engineer > Priority: Major > Attachments: HDDS-955-HDDS-4.001.patch, HDDS-955-HDDS-4.002.patch > > > Add CA to the SCM, this allows CA to be initialized automatically if security > is turned on. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org