[
https://issues.apache.org/jira/browse/HDFS-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737015#comment-16737015
]
Adam Antal commented on HDFS-14061:
-----------------------------------
Thank you for the patch [~knanasi].
- Being a bit more descriptive I would rename {{testEnablePolicy}}, for e.g.
to {{testEnablePolicyWarning}}. Also it might be worthwhile to test when the
number of racks equals exactly to the requirement, that this warning is NOT
raised.
- Also in {{FSNamesystem.java:getVerifyECWithTopologyResult()}}
{code:java}
ErasureCodingPolicy[] ecPolicies =
getErasureCodingPolicyManager().getCopyOfEnabledPolicies();
{code}
Since previously we listed all the policies, but now we handle the enabled
policies only, the name of the variable {{ecPolicies}} should be renamed to
{{enabledEcPolicies}} to reflect that.
- Although jenkins did not throw error, it may worth to review tests in
{{TestErasureCodingCLI}} as well (so the tests in the
{{testErasureCodingConf.xml}} file). Where the warning arises, a new comparator
should be added that checks (because it must be tested that the warning do come
up) and also optionally add a test there that would specifically checks for the
warning.
- I hope I did not miss anything, but is redirecting stderr in
{{TestECAdmin.java}} somewhat unrelated to this issue? You seemingly did not
add any more output to stderr - so to make sure: in {{ECAdmin.java:run()}} it
is {{System.out}} and not a {{System.err}} ?
> Check if the cluster topology supports the EC policy before setting, enabling
> or adding it
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-14061
> URL: https://issues.apache.org/jira/browse/HDFS-14061
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding, hdfs
> Affects Versions: 3.1.1
> Reporter: Kitti Nanasi
> Assignee: Kitti Nanasi
> Priority: Major
> Attachments: HDFS-14061.001.patch, HDFS-14061.002.patch
>
>
> HDFS-12946 introduces a command for verifying if there are enough racks and
> datanodes for the enabled erasure coding policies.
> This verification could be executed for the erasure coding policy before
> enabling, setting or adding it and a warning message could be written if the
> verify fails, or the policy setting could be even failed in this case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
