[
https://issues.apache.org/jira/browse/HDDS-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737315#comment-16737315
]
Elek, Marton commented on HDDS-965:
-----------------------------------
The patch fixes about 150 checkstyle issues. With the patch there is no more
checkstyle issue in hadoop-ozone/hadoop-hdds projects.
It also fixes the remaining ~10 findbugs issues.
It also adds some very simple scripts to build/check the project. I think it's
more easy to run all the required checks locally with the simplified scripts.
For example: hadoop-ozone/dev-support/checks/build.sh does a build (and we
don't need to explain all the required maven parameters for a new contributor)
hadoop-ozone/dev-support/checks/checkstyle.sh checks the checkstyle issues.
The last file in the patch is a Jenkinsfile which can be used to call all the
simple check scripts. With the help of the Jenkinsfile it's easy to process all
the PR on github. The example build is created on the apache jenkins:
[https://builds.apache.org/view/O/view/Ozone%20(Hadoop%20Ozone)/job/Ozone]
The build itself is executed in a docker. After HDDS-851 the docker file will
be moved to the separated repository and to the apache/ docker namespace. As of
now it's uploaded to the docker hub manually.
The build image itself contains pre-cached 3rd party maven artifacts (about
1GB). It makes the build extremly fast (25 minutes vs 2 minutes for one stage).
Even if the maven repo is separated for all the build the 3rd party jar files
are already downloaded to the docker image.
Follow-up TODOs:
* The detailed status lines are not yet updated in the github pr (see this
example about the goal: [https://github.com/elek/prcitest/pull/6)]
* The dockerfile will be moved to apache/ozone-build
* Acceptance test file exists but the results are not processed, yet. It
should be adjusted, but with this approach it will be easy to run for all the
PR builds.
> Ozone: checkstyle improvements and code quality scripts
> -------------------------------------------------------
>
> Key: HDDS-965
> URL: https://issues.apache.org/jira/browse/HDDS-965
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Experimental scripts to test github pr capabilities after the github url
> move. The provided scripts are easier to use locally and provides more
> strict/focused checks then the existing pre-commit scripts. But this is not a
> replacements of the existing yetus build as it adds additional (more strict)
> checks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
