[ https://issues.apache.org/jira/browse/HDFS-14158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747544#comment-16747544 ]
Hadoop QA commented on HDFS-14158: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color} | {color:red} HDFS-14158 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HDFS-14158 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12955577/HDFS-14158.patch | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/26014/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Checkpointer ignores configured time period > 5 minutes > ------------------------------------------------------- > > Key: HDFS-14158 > URL: https://issues.apache.org/jira/browse/HDFS-14158 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.8.1 > Reporter: Timo Walter > Priority: Minor > Labels: checkpoint, hdfs, namenode > Attachments: HDFS-14158.patch > > > The checkpointer always triggers a checkpoint every 5 minutes and ignores the > flag "*dfs.namenode.checkpoint.period*", if its greater than 5 minutes. > See the code below (in Checkpointer.java): > {code:java} > //Main work loop of the Checkpointer > public void run() { > // Check the size of the edit log once every 5 minutes. > long periodMSec = 5 * 60; // 5 minutes > if(checkpointConf.getPeriod() < periodMSec) { > periodMSec = checkpointConf.getPeriod(); > } > {code} > If the configured period ("*dfs.namenode.checkpoint.period*") is lower than 5 > minutes, you choose use the configured one. But it always ignores it, if it's > greater than 5 minutes. > > In my opinion, the if-expression should be: > {code:java} > if(checkpointConf.getPeriod() > periodMSec) { > periodMSec = checkpointConf.getPeriod(); > } > {code} > > Then "*dfs.namenode.checkpoint.period*" won't get ignored. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org