[ 
https://issues.apache.org/jira/browse/HDDS-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749746#comment-16749746
 ] 

Elek, Marton commented on HDDS-990:
-----------------------------------

Thanks [~adoroszlai] to take care of it.

I like the patch, I have only one comment:
{code:java}
Dozone.md
...Starting ozone in the `compose/ozone-hdfs` directory will also start 
NameNode and S3 gateway...{code}
I wouldn't add it to this line as it could be confusing. By default, ozone 
doesn't require namenode. ozone-hdfs is a very specific use case when ozone is 
started together with an existing hdfs. I would rather remove the line with the 
namenode ui address ('For the Namenode: [http://localhost:9870')]

Or later we can add an additional list to explain the differences between the 
different docker-compose dirs (which are usually documented in README files)

> Typos in Ozone doc
> ------------------
>
>                 Key: HDDS-990
>                 URL: https://issues.apache.org/jira/browse/HDDS-990
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>            Priority: Minor
>         Attachments: HDDS-990.001.patch, HDDS-990.002.patch
>
>
> Fix the following issues in {{hadoop-hdds/docs/content}}:
>  # {{bucket delete}} description and example references volume instead
>  # {{compose/ozone}} doesn't launch Namenode, only {{compose/ozone-hdfs}} does
>  # Java API example doesn't compile:
>  #* use regular quotes instead of "word-processor" ones
>  #* typo in variable and class names
>  # {{delete key}} -> {{key delete}}
>  # various other typos



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to