[
https://issues.apache.org/jira/browse/HDFS-14202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752965#comment-16752965
]
Ranith Sardar edited comment on HDFS-14202 at 1/26/19 8:57 AM:
---------------------------------------------------------------
Thanks, [~elgoiri] for the review.
{quote} What's the rationale behind numbers like 11936966 and 21936966?
{quote}
Just trying to move data which is more than 1MB, then only we can get proper
timeUsed to copy blocks. So, more than 1MB, we can put any random value and
timeUsed the corresponding value to move the data size.
{quote}The javadoc in the middle of {{testDiskBalancerComputeDelay()}} looks
weird.
{quote}
Can you please give some suggestions, how can we arrange javadoc.
{quote}You may want to mark as VisibleForTesting the changes of visibility only
for tests.{quote}
yes, will use Visiblefortesting, then will not need to change into "public".
was (Author: ranith):
Thanks, [~elgoiri] for the review.
{quote} What's the rationale behind numbers like 11936966 and 21936966?
{quote}
Just trying to move data which is more than 1MB, then only we can get proper
timeUsed to copy blocks. So, more than 1MB, we can put any random value and
timeUsed the corresponding value to move the data size.
{quote}The javadoc in the middle of {{testDiskBalancerComputeDelay()}} looks
weird.
{quote}
Can you please give some suggestions, how can we arrange javadoc.
{quote}{quote}
yes, will use Visiblefortesting, then will not need to change into "public".
> "dfs.disk.balancer.max.disk.throughputInMBperSec" property is not working as
> per set value.
> -------------------------------------------------------------------------------------------
>
> Key: HDFS-14202
> URL: https://issues.apache.org/jira/browse/HDFS-14202
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: diskbalancer
> Affects Versions: 3.0.1
> Reporter: Ranith Sardar
> Assignee: Ranith Sardar
> Priority: Major
> Attachments: HDFS-14202.001.patch, HDFS-14202.002.patch,
> HDFS-14202.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
