[
https://issues.apache.org/jira/browse/HDDS-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753705#comment-16753705
]
Shashikant Banerjee commented on HDDS-997:
------------------------------------------
Thanks [~nilotpalnandi] for working on this. The patch looks good to me. Some
minor comments:
1.While adding the tests in #test_scm_isolation_one_node and
#test_scm_isolation_two_node, let's also add the expected results in the
comments to make it more understandable.
2. Add a more meaningful log info while tearing down the blockade cluster
logging the cluster FILE location.
3.The test seem to waiting for 900 seconds to check the container status after
running freon? Can it made configurable in the tests?
4.ozoneblockade.json : -> is this file required?
5.test_datanode_isolation_all :-> empty line added. Please revert.
> Add blockade Tests for scm isolation and mixed node isolation
> -------------------------------------------------------------
>
> Key: HDDS-997
> URL: https://issues.apache.org/jira/browse/HDDS-997
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Nilotpal Nandi
> Assignee: Nilotpal Nandi
> Priority: Major
> Attachments: HDDS-997.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
