[ 
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753763#comment-16753763
 ] 

Sammi Chen edited comment on HDDS-699 at 1/30/19 3:09 AM:
----------------------------------------------------------

Hi [~junjie], thanks for your review and feedbacks.
{quote}For choosing a node (randomly or not), do we really need ancestor 
parameter? The scope should already contain the branch level info. Isn't it?
{quote}
The current NetworkTopology implementation allows user to define topology with 
any levels, so the node chosen flexibility is provided with the "ancestorGen" 
parameter. For a specific network topology, you are right, the level info is 
fixed, in the container/pipeline placement policy implementation. 
 The rest will be address in the coming patch.


was (Author: sammi):
Hi [~junjie],  thanks for your review and feedbacks. 

{code:java}
+    // Remove any trailing NetConf.PATH_SEPARATOR
+    int len = path.length();
+    while (len > 0 && path.charAt(len-1) == NetConf.PATH_SEPARATOR) {
+      path = path.substring(0, len-1);
+      len = path.length();
+    }
+    return path;
+  }
{code}
It's to remove the trailing "/". "/" in the middle can not be removed. 
{quote}
For choosing a node (randomly or not), do we really need ancestor parameter? 
The scope should already contain the branch level info. Isn't it?
{quote}
The current NetworkTopology implementation allows user to define topology with 
any levels, so the node chosen flexibility is provided with the "ancestorGen" 
parameter. For a specific network topology, you are right, the level info is 
fixed, in the container/pipeline placement policy implementation. 
The rest will be address in the coming patch. 



> Detect Ozone Network topology
> -----------------------------
>
>                 Key: HDDS-699
>                 URL: https://issues.apache.org/jira/browse/HDDS-699
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Xiaoyu Yao
>            Assignee: Sammi Chen
>            Priority: Major
>         Attachments: HDDS-699.00.patch, HDDS-699.01.patch
>
>
> Traditionally this has been implemented in Hadoop via script or customizable 
> java class. One thing we want to add here is the flexible multi-level support 
> instead of fixed levels like DC/Rack/NG/Node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to