[ https://issues.apache.org/jira/browse/HDDS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756831#comment-16756831 ]
Yiqun Lin edited comment on HDDS-1029 at 1/31/19 3:47 AM: ---------------------------------------------------------- I'm +1 for this idea, [~bharatviswa]. Some review comments from me: *Handler.java* Line154: Typo {{with out}} ==> {{without}} *ContainerController.java* Line119: Typo {{with out}} ==> {{without}} *ReplicationManager.java* Line219: Why the deletion behaviour here is forcible? From my understanding, the force behaviour is intended for the user/admin. *DeleteContainerCommand.java* I would add a constructor method with the default force flag, so that we don't need to pass the flag every time even when we don't want to delete container forcible. {code:java} public DeleteContainerCommand(long containerId) { this(containerId, false); } {code} Other: The error type of {{ERROR_CONTAINER_NOT_EMPTY}} is not threw after the change, there is no usage for this. Can we remove this type or leave this but with a comment? was (Author: linyiqun): I'm +1 for this idea, [~bharatviswa]. Some review comments from me: *Handler.java* Line154: Typo {{with out}} ==> {{without}} *ContainerController.java* Line119: Typo {{with out}} ==> {{without}} *DeleteContainerCommand.java* Line219: Why the deletion behaviour here is forcible? From my understanding, the force behaviour is intended for the user/admin. *DeleteContainerCommand.java* I would add a constructor method with the default force flag, so that we don't need to pass the flag every time even when we don't want to delete container forcible. {code:java} public DeleteContainerCommand(long containerId) { this(containerId, false); } {code} Other: The error type of {{ERROR_CONTAINER_NOT_EMPTY}} is not threw after the change, there is no usage for this. Can we remove this type or leave this but with a comment? > Allow option for force in DeleteContainerCommand > ------------------------------------------------ > > Key: HDDS-1029 > URL: https://issues.apache.org/jira/browse/HDDS-1029 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Bharat Viswanadham > Assignee: Bharat Viswanadham > Priority: Major > Attachments: HDDS-1029.00.patch, HDDS-1029.01.patch, > HDDS-1029.02.patch > > > Right now, we check container state if it is not open, and then we delete > container. > We need a way to delete the containers which are open, so adding a force flag > will allow deleting a container without any state checks. (This is required > for delete replica's when SCM detects over-replicated, and that container to > delete can be in open state) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org