[ 
https://issues.apache.org/jira/browse/HDFS-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106883#comment-13106883
 ] 

Todd Lipcon commented on HDFS-2306:
-----------------------------------

- Not crazy about the new config name... "dfs.namenode.checkpoint.events" is 
kind of vague. Perhaps dfs.namenode.checkpoint.history.retained ?
- missing license on CheckpointEvent.java
- does CheckpointEvent need to be public in order to work as part of JMX? I'm 
not a JMX pro. If public, it should have audience/stability annotations
- we may want to expose getSyncTxId() instead of getLastWrittenTxId()
- typo "insce the last checkpoint" in NameNodeMXBean
- getRecentCheckpointEvents doesn't return a copy of the list, so the web page 
may throw ConcurrentModificationException. Perhaps change 
recentCheckpointEvents to be a CopyOnWriteArrayList? Or return a copy?

I'm still unclear on what the fields are inside CheckpointEvent... maybe we can 
sync up offline to discuss.


> NameNode web UI should show information about recent checkpoints
> ----------------------------------------------------------------
>
>                 Key: HDFS-2306
>                 URL: https://issues.apache.org/jira/browse/HDFS-2306
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>             Fix For: 0.24.0
>
>         Attachments: checkpoint-history.1.png, checkpoint-history.png, 
> hdfs-2306.0.patch, hdfs-2306.1.patch
>
>
> It would be nice if the NN web UI showed the 2NN address, timestamp, number 
> of edits, etc. of the last few checkpoints.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to