[ https://issues.apache.org/jira/browse/HDDS-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768903#comment-16768903 ]
Yiqun Lin edited comment on HDDS-1106 at 2/15/19 3:07 AM: ---------------------------------------------------------- [~ljain], a quick review for the patch. Why not also make {{State}} as one condition in {{PipelineQuery}}? Then we can completely remove the traversing entries behaviour. Checkstyle issues: {nofomat} ./hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateMap.java:327: ReplicationType type;:21: Variable 'type' must be private and have accessor methods. [VisibilityModifier] ./hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateMap.java:328: ReplicationFactor factor;:23: Variable 'factor' must be private and have accessor methods. [VisibilityModifier] {nofomat} was (Author: linyiqun): [~ljain], a quick review for the patch. Why not also make {{State}} as one condition in {{PipelineQuery}}? Then we can completely remove the traversing entries behaviour. > Introduce queryMap in PipelineManager > ------------------------------------- > > Key: HDDS-1106 > URL: https://issues.apache.org/jira/browse/HDDS-1106 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Lokesh Jain > Assignee: Lokesh Jain > Priority: Major > Fix For: 0.4.0 > > Attachments: HDDS-1106.001.patch > > > In Genesis benchmark for block allocation it was found that > BlockManager#allocateBlock call was very slow for higher number of pipelines. > This happens because allocateBlock call gets list of pipelines with a > particular replication type, replication factor and state. This list is > calculated by traversing the entries of a map. This Jira aims to optimize the > call by introducing query map in Pipeline Manager. > The pipeline manager would keep a maintain a list of pipelines for every > query type i.e. for every replication type, replication factor. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org