[
https://issues.apache.org/jira/browse/HDDS-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768945#comment-16768945
]
Xiaoyu Yao commented on HDDS-1101:
----------------------------------
Thanks [~anu] for the patch. It looks good to me overall. Here are a few minor
comments:
DefaultApprover.java
Line 104: is there a reason to use Time.monotonicNowNanos() as the serialID for
the certificate? This maybe OK for a single SCM case. But the ID may collide
when there are multiple SCM instances. Should reserve certain bits to partition
the scm ids?
DefaultCAServer.java
Line 213: should we store after xcertHolder.complete(xcert);?
Line 245-250: should we wrap this with supplyAsync to make the revoke truly
async?
StorageContainerManager.java
Line 266: NIT: typo "afte" should be "after"
Line 268: question wrt. the configurator usage: why don't we populate the value
initialized back into the configurator with the setters or just assume only the
injector will set it?
Line 531: should we move the certStore down to internal of DefaultCAServer?
TestOmMultiPartKeyInfoCodec.java
Line 57: NIT: typo: random
> SCM CA: Write Certificate information to SCM Metadata
> -----------------------------------------------------
>
> Key: HDDS-1101
> URL: https://issues.apache.org/jira/browse/HDDS-1101
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: SCM
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Major
> Attachments: HDDS-1101.000.patch
>
>
> Make SCM CA write to the Metadata layer of SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
