[
https://issues.apache.org/jira/browse/HDDS-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16770836#comment-16770836
]
Mukul Kumar Singh commented on HDDS-726:
----------------------------------------
Thanks for working on this [~shashikant]. The patch generally looks good to me.
Please find me comments as following.
1) BlockManagerImpl.java:202, the implementation streams all the allocated
container and then finds the one not matching the size. This can result in
allocate block to fail even when other container are present from which the
blocks can be allocated.
2) PipelineStateMap:221, the excludedn and exclude pipeline are both calling
the same function, discardPipeline:230
3) SCMPipelineManager:198, lets rename pipelineIds to excludePipelines or
similar.
> Ozone Client should update SCM to move the container out of allocation path
> in case a write transaction fails
> -------------------------------------------------------------------------------------------------------------
>
> Key: HDDS-726
> URL: https://issues.apache.org/jira/browse/HDDS-726
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Attachments: HDDS-726.000.patch, HDDS-726.001.patch,
> HDDS-726.002.patch, HDDS-726.003.patch, HDDS-726.004.patch
>
>
> Once an container write transaction fails, it will be marked corrupted. Once
> Ozone client gets an exception in such case it should tell SCM to move the
> container out of allocation path. SCM will eventually close the container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
