[ https://issues.apache.org/jira/browse/HDFS-14287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771303#comment-16771303 ]
Íñigo Goiri commented on HDFS-14287: ------------------------------------ Interesting that we actually had a "closed" variable but wasn't properly used. For clarity, I'm removing the multiple attachments of the same patch. TestJournalNodeSync is failing but it seems unrelated. +1 > DataXceiverServer May Double-Close PeerServer > --------------------------------------------- > > Key: HDFS-14287 > URL: https://issues.apache.org/jira/browse/HDFS-14287 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 3.2.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Attachments: HDFS-14287.1.patch > > > Based on my work with [HDFS-14258], I noticed that when a user calls the > {{kill()}} method in {{DataXceiverServer}}, it closes the {{PeerServer}}. > This causes the thread responsible for receiving connections from the > {{PeerServer}} to interrupt and then exit. On the way out, this thread also > [closes|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java#L246-L253] > the {{PeerServer}} for good measure. I'm not sure what the affects of > closing the {{PeerServer}} are twice, but it should be avoided. > To be clear, this is not a regressions caused by [HDFS-14258], if anything, > [HDFS-14258] makes it easier to fix. :) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org