[ https://issues.apache.org/jira/browse/HDFS-14259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772868#comment-16772868 ]
Ranith Sardar commented on HDFS-14259: -------------------------------------- [~elgoiri], Attached the patch. Please review once. > RBF: Fix safemode message for Router > ------------------------------------ > > Key: HDFS-14259 > URL: https://issues.apache.org/jira/browse/HDFS-14259 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Íñigo Goiri > Assignee: Ranith Sardar > Priority: Major > Attachments: HDFS-14259-HDFS-13891.000.patch, > HDFS-14259-HDFS-13891.001.patch > > > Currently, the {{getSafemode()}} bean checks the state of the Router but > returns the error if the status is different than SAFEMODE: > {code} > public String getSafemode() { > if (!getRouter().isRouterState(RouterServiceState.SAFEMODE)) { > return "Safe mode is ON. " + this.getSafeModeTip(); > } > } catch (IOException e) { > return "Failed to get safemode status. Please check router" > + "log for more detail."; > } > return ""; > } > {code} > The condition should be reversed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org