[ 
https://issues.apache.org/jira/browse/HDDS-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775055#comment-16775055
 ] 

Yiqun Lin commented on HDDS-1120:
---------------------------------

Thanks for addressing the comment, [~bharatviswa]! Only one small suggestion: 
Can we reuse common linesĀ in two test case? I mean we can extract follow lines 
to a method.
{code:java}
 String volumeName = UUID.randomUUID().toString();
 String bucketName = UUID.randomUUID().toString();
 
 String value = "sample value";
 store.createVolume(volumeName);
 OzoneVolume volume = store.getVolume(volumeName);
 volume.createBucket(bucketName);
 OzoneBucket bucket = volume.getBucket(bucketName);
 String keyName = UUID.randomUUID().toString();
 
 // Write data into a key
 OzoneOutputStream out = bucket.createKey(keyName,
 value.getBytes().length, ReplicationType.RATIS,
 ReplicationFactor.ONE, new HashMap<>());
 out.write(value.getBytes());
 out.close();
 
 // We need to find the location of the chunk file corresponding to the
 // data we just wrote.
 OzoneKey key = bucket.getKey(keyName);
 long containerID = ((OzoneKeyDetails) key).getOzoneKeyLocations().get(0)
 .getContainerID();
 
 // Get the container by traversing the datanodes. Atleast one of the
 // datanode must have this container.
 Container container = null;
 ...
 Assert.assertNotNull("Container not found", container);
{code}

> Add a config to disable checksum verification during read even though 
> checksum data is present in the persisted data
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDDS-1120
>                 URL: https://issues.apache.org/jira/browse/HDDS-1120
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Client
>    Affects Versions: 0.4.0
>            Reporter: Shashikant Banerjee
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.4.0
>
>         Attachments: HDDS-1120.00.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, if the checksum is computed during data write and persisted in the 
> disk, we will always end up verifying it while reading. This Jira aims to 
> selectively disable checksum verification during reads even though checksum 
> info is present in the data stored.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to