[ https://issues.apache.org/jira/browse/HDDS-1113?focusedWorklogId=203333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203333 ]
ASF GitHub Bot logged work on HDDS-1113: ---------------------------------------- Author: ASF GitHub Bot Created on: 24/Feb/19 22:31 Start Date: 24/Feb/19 22:31 Worklog Time Spent: 10m Work Description: anuengineer commented on issue #490: HDDS-1113. Remove default dependencies from hadoop-ozone project URL: https://github.com/apache/hadoop/pull/490#issuecomment-466824443 I thought we fixed this, but I get this error when I build with this patch applied. > [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (depcheck) @ hadoop-ozone-common --- [WARNING] Dependency convergence error for com.squareup.okio:okio:1.6.0 paths to dependency are: +-org.apache.hadoop:hadoop-ozone-common:0.4.0-SNAPSHOT +-org.apache.hadoop:hadoop-hdfs-client:3.2.0 +-com.squareup.okhttp:okhttp:2.7.5 +-com.squareup.okio:okio:1.6.0 and +-org.apache.hadoop:hadoop-ozone-common:0.4.0-SNAPSHOT +-org.apache.hadoop:hadoop-hdds-common:0.4.0-SNAPSHOT +-io.jaegertracing:jaeger-client:0.33.1 +-io.jaegertracing:jaeger-thrift:0.33.1 +-com.squareup.okhttp3:okhttp:3.9.0 +-com.squareup.okio:okio:1.13.0 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 203333) Time Spent: 0.5h (was: 20m) > Remove default dependencies from hadoop-ozone project > ----------------------------------------------------- > > Key: HDDS-1113 > URL: https://issues.apache.org/jira/browse/HDDS-1113 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: build > Reporter: Elek, Marton > Assignee: Elek, Marton > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > There are two ways to define common dependencies with maven: > 1.) put all the dependencies to the parent project and inherit them > 2.) get all the dependencies via transitive dependencies > TLDR; I would like to switch from 1 to 2 in hadoop-ozone > My main problem with the first approach that all the child project get a lot > of dependencies independent if they need them or not. Let's imagine that I > would like to create a new project (for example a java csi implementation) It > doesn't need ozone-client, ozone-common etc, in fact it conflicts with > ozone-client. But these jars are always added as of now. > Using transitive dependencies is more safe: we can add the dependencies where > we need them and all of the other dependent projects will use them. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org