[ 
https://issues.apache.org/jira/browse/HDFS-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779586#comment-16779586
 ] 

Vinayakumar B commented on HDFS-7663:
-------------------------------------

Thanks [~ayushtkn] for the update on the patch.

One more minor change.
{code:java}
     LocatedBlock ret = null;
     if (!newBlock) {
+      if (file.isStriped()) {
+        throw new UnsupportedActionException(
+            "Append on EC file without new block is not supported.");
+      }
{code}
Instead of {{UnsupportedActionException}}, throw 
{{UnsupportedOperationException}} as before.


+1, once this change is done.

> Erasure Coding: Append on striped file
> --------------------------------------
>
>                 Key: HDFS-7663
>                 URL: https://issues.apache.org/jira/browse/HDFS-7663
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Jing Zhao
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-7663-02.patch, HDFS-7663-03.patch, 
> HDFS-7663-04.patch, HDFS-7663-05.patch, HDFS-7663.00.txt, HDFS-7663.01.patch
>
>
> Append should be easy if we have variable length block support from 
> HDFS-3689, i.e., the new data will be appended to a new block. We need to 
> revisit whether and how to support appending data to the original last block.
> 1. Append to a closed striped file, with NEW_BLOCK flag enabled (this)
> 2. Append to a under-construction striped file, with NEW_BLOCK flag enabled 
> (HDFS-9173)
> 3. Append to a striped file, by appending to last block group (follow-on)
> This jira attempts to implement the #1, and also track #2, #3.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to