[ 
https://issues.apache.org/jira/browse/HDFS-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782569#comment-16782569
 ] 

Íñigo Goiri commented on HDFS-14329:
------------------------------------

Thanks [~ayushtkn] for the patch.
This is similar to what we did in HDFS-14167.
A few comments:
* Avoid the break line in FederationMBean#155.
* Shortening {{numInMainLive}} is a little misleading with main; Maint? Or even 
full Maintenance?
* No point on changing NUM_BLOCK_MISSING from 1000 to 211.

> RBF: Add maintenance nodes to federation metrics
> ------------------------------------------------
>
>                 Key: HDFS-14329
>                 URL: https://issues.apache.org/jira/browse/HDFS-14329
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14329-HDFS-13891-01.patch
>
>
> Extend datanode maintenance related metrics into federation metrics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to