[
https://issues.apache.org/jira/browse/HDDS-1214?focusedWorklogId=207759&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207759
]
ASF GitHub Bot logged work on HDDS-1214:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/19 12:03
Start Date: 05/Mar/19 12:03
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #550: HDDS-1214. Enable
tracing for the datanode read/write path
URL: https://github.com/apache/hadoop/pull/550#issuecomment-469655140
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 43 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 14 | Maven dependency ordering for branch |
| +1 | mvninstall | 1074 | trunk passed |
| +1 | compile | 74 | trunk passed |
| +1 | checkstyle | 29 | trunk passed |
| +1 | mvnsite | 70 | trunk passed |
| +1 | shadedclient | 795 | branch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 126 | trunk passed |
| +1 | javadoc | 69 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 15 | Maven dependency ordering for patch |
| +1 | mvninstall | 77 | the patch passed |
| +1 | compile | 74 | the patch passed |
| +1 | javac | 74 | the patch passed |
| +1 | checkstyle | 23 | the patch passed |
| +1 | mvnsite | 67 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 758 | patch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 134 | the patch passed |
| +1 | javadoc | 64 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 82 | common in the patch failed. |
| +1 | unit | 66 | container-service in the patch passed. |
| +1 | asflicense | 32 | The patch does not generate ASF License warnings. |
| | | 3721 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-550/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/550 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux fc16b419e907 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 0aefe28 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-550/2/artifact/out/patch-unit-hadoop-hdds_common.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-550/2/testReport/ |
| Max. process+thread count | 327 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service U:
hadoop-hdds |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-550/2/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 207759)
Time Spent: 0.5h (was: 20m)
> Enable tracing for the datanode read/write path
> -----------------------------------------------
>
> Key: HDDS-1214
> URL: https://issues.apache.org/jira/browse/HDDS-1214
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HDDS-1150 introduced distributed for ozone components. But we have no trace
> context propagation between the clients and Ozone Datanodes.
> As we use Grpc and Ratis on this RPC path the full tracing could be quite
> complex: we should propagate the trace id in Ratis and include it in all the
> log entries.
> I propose a simplified solution here: to trace only the StateMachine
> operations.
> As Ratis is a library we provide the implementation of the appropriate Raft
> elements especially the StateMachine and the raft messages. We can add the
> tracing information to the raft messages (in fact, we already have this
> field) and we can restore the tracing context during the StateMachine
> operations.
> This approach is very simple (only a few lines of codes) and can show the
> time of the real write/read operations, but can't see the internals of the
> Ratis operations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
