[
https://issues.apache.org/jira/browse/HDFS-14343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787134#comment-16787134
]
Íñigo Goiri commented on HDFS-14343:
------------------------------------
{quote}
For a file that is not present. The file status returned is null rather than
giving a FileNotFoundException. So we can have a null check at
RouterClientProtocol#1880
{quote}
Perfect, let's just constrain the exceptions we expect and log error for the
generic exception.
Maybe even throw those and let them surface.
{quote}
Regarding the symlink. I guess getFileInfo isn't behaving as we want. For
symLink instead returning the status. It throws back exception telling it is
symlink, It has a check for symLink at namenode side. So I guess for this we
need to catch exception. If I am ain't missing something.
{quote}
Yes, let's catch {{UnresolvedPathException}}.
The current unit test should have good coverage for this.
{quote}
I didn't catch this. Do you mean checking if there is file in all subclusters?
If so, if we invoke RPC at all subcluster. we would land back to the stage
worse than directly calling invokeAll after checking isPathAll() in terms of
RPC calls.(since now we are having an overhead of calculation too).
{quote}
I was just referring to checking for files within the directories to make sure
they were in the src and then they are in the dst too.
It wouldn't hurt to add the rename of a file too (even though it is covered by
TestRouteRpc*); it would be just one line in the unit test.
> RBF: Fix renaming folders spread across multiple subclusters
> ------------------------------------------------------------
>
> Key: HDFS-14343
> URL: https://issues.apache.org/jira/browse/HDFS-14343
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-14343-HDFS-13891-01.patch,
> HDFS-14343-HDFS-13891-02.patch
>
>
> The {{RouterClientProtocol#rename()}} function assumes that we are renaming
> files and only renames one of them (i.e., {{invokeSequential()}}). In the
> case of folders which are in all subclusters (e.g., HASH_ALL) we should
> rename all locations (i.e., {{invokeAll()}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
