[jira] [Created] (HDFS-14361) SNN will always upload fsimage

[hunshenshi (JIRA)]

hunshenshi created HDFS-14361:
---------------------------------

             Summary: SNN will always upload fsimage
                 Key: HDFS-14361
                 URL: https://issues.apache.org/jira/browse/HDFS-14361
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: ha, namenode
    Affects Versions: 3.2.0
            Reporter: hunshenshi
             Fix For: 3.2.0


{code:java}
boolean sendRequest = isPrimaryCheckPointer
    || secsSinceLastUpload >= checkpointConf.getQuietPeriod();
doCheckpoint(sendRequest);
{code}
If sendRequest is true, SNN will upload fsimage. But isPrimaryCheckPointer 
always is true,
{code:java}
if (ie == null && ioe == null) {
  //Update only when response from remote about success or
  lastUploadTime = monotonicNow();
  // we are primary if we successfully updated the ANN
  this.isPrimaryCheckPointer = success;
}
{code}
isPrimaryCheckPointer should be outside the if condition. If the ANN update was 
not successful, then isPrimaryCheckPointer should be set to false.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org