[
https://issues.apache.org/jira/browse/HDDS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791100#comment-16791100
]
Tsz Wo Nicholas Sze commented on HDDS-699:
------------------------------------------
Some final comments:
- There are some code duplication in NetworkTopologyImpl
-* getNode(..) and one of the chooseRandom(..) are mostly the same. We should
refactor them.
-* Different versions of chooseRandom(..) should just call the most general
chooseRandom(..) method.
- Some items in [this
comment|https://issues.apache.org/jira/browse/HDDS-699?focusedCommentId=16786253&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16786253]
are not yet addressed.
- There are a few checkstyle warnings.
Thanks!
> Detect Ozone Network topology
> -----------------------------
>
> Key: HDDS-699
> URL: https://issues.apache.org/jira/browse/HDDS-699
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Sammi Chen
> Priority: Major
> Attachments: HDDS-699.00.patch, HDDS-699.01.patch, HDDS-699.02.patch,
> HDDS-699.03.patch, HDDS-699.04.patch, HDDS-699.05.patch, HDDS-699.06.patch
>
>
> Traditionally this has been implemented in Hadoop via script or customizable
> java class. One thing we want to add here is the flexible multi-level support
> instead of fixed levels like DC/Rack/NG/Node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
