[
https://issues.apache.org/jira/browse/HDDS-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791389#comment-16791389
]
Mukul Kumar Singh commented on HDDS-1098:
-----------------------------------------
Thanks for working on this [~shashikant]. The patch looks good to me. Some
comments as following.
1) There are checkstyle and whitespace issues with the patch
2) There are no changes in BufferPool.java, please revert the file.
3) KeyOutputStream.java:474, this code should be incapsulated inside
delayMillis > 0. In case the delayMillis is zero, this will not be executed.
4) checkForException, in place of returning null, the function can throw the
exception.
5)KeyOutputStream.java:428, the pipeline should be added to the exclude list
> Introduce Retry Policy in Ozone Client
> --------------------------------------
>
> Key: HDDS-1098
> URL: https://issues.apache.org/jira/browse/HDDS-1098
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Client
> Affects Versions: 0.4.0
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Critical
> Fix For: 0.4.0
>
> Attachments: HDDS-1098.000.patch, HDDS-1098.001.patch
>
>
> Currently , ozone client indefinitely retries to failover to a new block
> write in case it encounters exceptions during write. The aim here is to bring
> in retry policy in the client so that indefinite retries should go away.
> Ozone client code will also be refactored as a part of this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
