[ https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792198#comment-16792198 ]
Bharat Viswanadham commented on HDDS-918: ----------------------------------------- +1 LGTM. One question, I see import change in ContainerStateManager, is there any reason for changing the order? > Expose SCMMXBean as a MetricsSource > ----------------------------------- > > Key: HDDS-918 > URL: https://issues.apache.org/jira/browse/HDDS-918 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Bharat Viswanadham > Assignee: Siddharth Wagle > Priority: Major > Labels: newbie > Attachments: HDDS-918.01.patch, HDDS-918.02.patch, HDDS-918.03.patch, > HDDS-918.04.patch, HDDS-918.05.patch, HDDS-918.06.patch, HDDS-918.07.patch > > > Implement MetricsSource interface, so that external metrics can collect the > SCMMXBean metrics information. > > From *MetricsSource.java:* > It registers with \{@link MetricsSystem}, which periodically polls it to > collect \{@link MetricsRecord} and passes it to \{@link MetricsSink}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org