[
https://issues.apache.org/jira/browse/HDDS-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793148#comment-16793148
]
Siddharth Wagle edited comment on HDDS-1233 at 3/14/19 11:05 PM:
-----------------------------------------------------------------
Review of patch version 001.
- "recon.om.connection.timeout", specify millis, same for other configs
- ReconUtils seems to provide configuration key, should probably be named
appropriately
- untarCheckpointFile, increase READ/WRITE buffer sizes.
- Don't see the need for ReconOMMetadataManagerProvider, the interface can be
bound to the impl in Singleton scope
- ReconContainerDBProvider might return null, try to inject dependencies that
are needed by the provider and usually return null creates side-effect code see
if that can be avoided.
- omMetadataManager.start(configuration); This looks scary as if OM is
started by Recon although its noop. Should rename if it does not start a thread.
was (Author: swagle):
- "recon.om.connection.timeout", specify millis, same for other configs
- ReconUtils seems to provide configuration key, should probably be named
appropriately
- untarCheckpointFile, increase READ/WRITE buffer sizes.
- Don't see the need for ReconOMMetadataManagerProvider, the interface can be
bound to the impl in Singleton scope
- ReconContainerDBProvider might return null, try to inject dependencies that
are needed by the provider and usually return null creates side-effect code see
if that can be avoided.
- omMetadataManager.start(configuration); This looks scary as if OM is
started by Recon although its noop. Should rename if it does not start a thread.
> Create an Ozone Manager Service provider for Recon.
> ---------------------------------------------------
>
> Key: HDDS-1233
> URL: https://issues.apache.org/jira/browse/HDDS-1233
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
> Reporter: Aravindan Vijayan
> Assignee: Aravindan Vijayan
> Priority: Major
> Fix For: 0.5.0
>
> Attachments: HDDS-1233-000.patch, HDDS-1233-001.patch
>
>
> * Implement an abstraction to let Recon make OM specific requests.
> * At this point of time, the only request is to get the DB snapshot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
