[ https://issues.apache.org/jira/browse/HDFS-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116448#comment-13116448 ]
Hudson commented on HDFS-2363: ------------------------------ Integrated in Hadoop-Mapreduce-trunk #844 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/844/]) HDFS-2363. Move datanodes size printing from FSNamesystem.metasave(..) to BlockManager. Contributed by Uma Maheswara Rao G szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176733 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java > Move datanodes size printing to BlockManager from FSNameSystem's metasave API > ----------------------------------------------------------------------------- > > Key: HDFS-2363 > URL: https://issues.apache.org/jira/browse/HDFS-2363 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: name-node > Affects Versions: 0.23.0, 0.24.0 > Reporter: Uma Maheswara Rao G > Assignee: Uma Maheswara Rao G > Priority: Minor > Fix For: 0.23.0, 0.24.0 > > Attachments: HDFS-2363.patch > > > {code} > final List<DatanodeDescriptor> live = new > ArrayList<DatanodeDescriptor>(); > final List<DatanodeDescriptor> dead = new > ArrayList<DatanodeDescriptor>(); > blockManager.getDatanodeManager().fetchDatanodes(live, dead, false); > out.println("Live Datanodes: "+live.size()); > out.println("Dead Datanodes: "+dead.size()); > blockManager.metaSave(out); > {code} > Logically all the dataNode related logic can be moved to BlockManager. > So, here metaSave API is getting the DataNodes details from blockManager to > FsNameSystem and after printing the details again it is giving the control to > blockManager. > It will be good to move the DNs size printing code also to BlockManager. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira