[
https://issues.apache.org/jira/browse/HDFS-14374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793942#comment-16793942
]
Íñigo Goiri commented on HDFS-14374:
------------------------------------
Thanks [~crh] for the patch; a few comments:
* Can you do an static import for assertEquals()? The rest may use the whole
syntax but I think we should start using just assertEquals().
* The expected value should be the first parameter for assertEquals().
* For the initialization of {{TestDelegationTokenSecretManager()}} can we use
values like: {{TimeUnit.DAYS.toMillis(7)}}?
* In the javadoc for {{getCurrentTokensSize()}} we should say that cancelled
tokens don't count. Basically describe what we are testing in
{{testDelegationTokenCount()}}.
> Expose total number of delegation tokens in
> AbstractDelegationTokenSecretManager
> --------------------------------------------------------------------------------
>
> Key: HDFS-14374
> URL: https://issues.apache.org/jira/browse/HDFS-14374
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: CR Hota
> Assignee: CR Hota
> Priority: Major
> Attachments: HDFS-14374.001.patch, HDFS-14374.002.patch
>
>
> AbstractDelegationTokenSecretManager should expose total number of active
> delegation tokens for specific implementations to track for observability.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
