[
https://issues.apache.org/jira/browse/HDDS-1250?focusedWorklogId=214078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214078
]
ASF GitHub Bot logged work on HDDS-1250:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/19 22:28
Start Date: 15/Mar/19 22:28
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #591: HDDS-1250: IIn OM
HA AllocateBlock call where connecting to SCM from OM should not happen on
Ratis.
URL: https://github.com/apache/hadoop/pull/591#issuecomment-473460817
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 503 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 2 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 49 | Maven dependency ordering for branch |
| +1 | mvninstall | 1024 | trunk passed |
| +1 | compile | 104 | trunk passed |
| +1 | checkstyle | 24 | trunk passed |
| -1 | mvnsite | 27 | ozone-manager in trunk failed. |
| +1 | shadedclient | 723 | branch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| -1 | findbugs | 24 | ozone-manager in trunk failed. |
| +1 | javadoc | 79 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 14 | Maven dependency ordering for patch |
| +1 | mvninstall | 101 | the patch passed |
| +1 | compile | 93 | the patch passed |
| +1 | cc | 93 | the patch passed |
| +1 | javac | 93 | the patch passed |
| +1 | checkstyle | 23 | hadoop-ozone: The patch generated 0 new + 1
unchanged - 1 fixed = 1 total (was 2) |
| +1 | mvnsite | 85 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 735 | patch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| +1 | findbugs | 109 | the patch passed |
| +1 | javadoc | 73 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 37 | common in the patch passed. |
| +1 | unit | 42 | ozone-manager in the patch passed. |
| -1 | unit | 1043 | integration-test in the patch failed. |
| +1 | asflicense | 26 | The patch does not generate ASF License warnings. |
| | | 5109 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.ozShell.TestOzoneShell |
| | hadoop.ozone.om.TestOzoneManager |
| | hadoop.ozone.client.rpc.TestReadRetries |
| | hadoop.ozone.om.TestScmChillMode |
| | hadoop.ozone.web.client.TestKeysRatis |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler
|
| | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient |
| | hadoop.ozone.om.TestContainerReportWithKeys |
| | hadoop.ozone.om.TestMultipleContainerReadWrite |
| | hadoop.ozone.TestStorageContainerManager |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler
|
| | hadoop.ozone.client.rpc.TestContainerStateMachine |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
|
| | hadoop.ozone.client.rpc.TestBCSID |
| | hadoop.ozone.web.client.TestKeys |
| | hadoop.ozone.client.rpc.TestContainerStateMachineFailures |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| | hadoop.ozone.om.TestOmBlockVersioning |
| | hadoop.ozone.web.TestOzoneRestWithMiniCluster |
| | hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/11/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/591 |
| JIRA Issue | HDDS-1250 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle cc |
| uname | Linux 45cf5d7b3fb9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 16b7862 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| mvnsite |
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/11/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt
|
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/11/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/11/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/11/testReport/ |
| Max. process+thread count | 5403 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager
hadoop-ozone/integration-test U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/11/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 214078)
Time Spent: 3h (was: 2h 50m)
> In OM HA AllocateBlock call where connecting to SCM from OM should not happen
> on Ratis
> --------------------------------------------------------------------------------------
>
> Key: HDDS-1250
> URL: https://issues.apache.org/jira/browse/HDDS-1250
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> In OM HA, currently when allocateBlock is called, in applyTransaction() on
> all OM nodes, we make a call to SCM and write the allocateBlock information
> into OM DB. The problem with this is, every OM allocateBlock and appends new
> BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's
> should have the same block information for a key, even though eventually this
> might be changed during key commit)
>
> The proposed approach is:
> 1. Calling SCM for allocation of block will happen outside of ratis, and this
> block information is passed and writing to DB will happen via Ratis.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
