[ https://issues.apache.org/jira/browse/HDDS-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794681#comment-16794681 ]
Yiqun Lin commented on HDDS-1295: --------------------------------- Hi [~msingh], looks fine to add this test, some minor comments: *MiniOzoneClusterImpl* Line 495: We can remove the {{private}} instead of making it {{public}}. *KeyOutputStream* Line 407: Lack of a ',' before {{iteration}}. Should be {{, iteration:{}}}. *MiniOzoneChaosCluster* Line 64: Can we update {{number}} to {{Number}}? Line 157: Lack of one white space after word {{exception}}. Line 173: The same problem to Line 157. One additional comment: {quote} This test can be controlled via command line parameters to determine the run duration and failure rates. {quote} I didn't see this implementation, is v01 patch not a complete patch? Current some parameters were just hard-coded. > Add MiniOzoneChaosCluster to mimic long running workload in a unit test > environment > ----------------------------------------------------------------------------------- > > Key: HDDS-1295 > URL: https://issues.apache.org/jira/browse/HDDS-1295 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: test > Affects Versions: 0.4.0 > Reporter: Mukul Kumar Singh > Assignee: Mukul Kumar Singh > Priority: Major > Attachments: HDDS-1295.001.patch > > > MiniOzoneChaosCluster will mimic various error cases in Ozone Cluster right > from Ozone Client to OzoneDatanodes. > This test can be controlled via command line parameters to determine the run > duration and failure rates. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org