[
https://issues.apache.org/jira/browse/HDDS-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795595#comment-16795595
]
Yiqun Lin commented on HDDS-1233:
---------------------------------
Almost looks great now, some minor comemnts:
As we has supported the time-unit suffixes, the variable names can updated:
RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_MINUTES-->RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY
RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_MINUTES_DEFAULT
-->RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY_DEFAULT
RECON_OM_SNAPSHOT_TASK_INTERVAL_MINUTES -->RECON_OM_SNAPSHOT_TASK_INTERVAL
RECON_OM_SNAPSHOT_TASK_INTERVAL_MINUTES_DEFAULT->RECON_OM_SNAPSHOT_TASK_INTERVAL_DEFAULT
In the UT of {{TestOzoneManagerServiceProviderImpl#start}}}, we don't really
need to sleep so long time (Thread.sleep(TimeUnit.SECONDS.toMillis(20)) to wait
for the update, Re-Configure {{RECON_OM_SNAPSHOT_TASK_INTERVAL}} and
{{RECON_OM_SNAPSHOT_TASK_INITIAL_DELAY}} to a short time can help this.
> Create an Ozone Manager Service provider for Recon.
> ---------------------------------------------------
>
> Key: HDDS-1233
> URL: https://issues.apache.org/jira/browse/HDDS-1233
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
> Reporter: Aravindan Vijayan
> Assignee: Aravindan Vijayan
> Priority: Major
> Fix For: 0.5.0
>
> Attachments: HDDS-1233-000.patch, HDDS-1233-001.patch,
> HDDS-1233-002.patch, HDDS-1233-003.patch
>
>
> * Implement an abstraction to let Recon make OM specific requests.
> * At this point of time, the only request is to get the DB snapshot.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
