[
https://issues.apache.org/jira/browse/HDFS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116899#comment-13116899
]
Suresh Srinivas edited comment on HDFS-2298 at 9/28/11 11:41 PM:
-----------------------------------------------------------------
bq. ClientProtocol#rename() has two signatures, one deprecated (HDFS-654). Both
are still used, since they have different semantics. Since the protocol methods
are private, it is safe to rename one. The user API can still be overloaded.
The new version is now called rename2. The best practice for interoperability
when changing semantics of RPC methods is to add a new method.
Doug you argued against this. See
https://issues.apache.org/jira/browse/HADOOP-6240?focusedCommentId=12752647&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12752647
That said, I am okay with renaming the method.
Given that this has been open for a while, for now can you turn off the test?
was (Author: sureshms):
bq. ClientProtocol#rename() has two signatures, one deprecated (HDFS-654).
Both are still used, since they have different semantics. Since the protocol
methods are private, it is safe to rename one. The user API can still be
overloaded. The new version is now called rename2. The best practice for
interoperability when changing semantics of RPC methods is to add a new method.
Doug you argued against this. See
https://issues.apache.org/jira/secure/EditComment!default.jspa?id=12434871&commentId=12752647
That said, I am okay with renaming the method.
Given that this has been open for a while, for now can you turn off the test?
> TestDfsOverAvroRpc is failing on trunk
> --------------------------------------
>
> Key: HDFS-2298
> URL: https://issues.apache.org/jira/browse/HDFS-2298
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Aaron T. Myers
> Assignee: Doug Cutting
> Fix For: 0.23.0, 0.24.0
>
> Attachments: HDFS-2298.patch, HDFS-2298.patch, HDFS-2298.patch,
> HDFS-2298.patch, HDFS-2298.patch
>
>
> The relevant bit of the error:
> {noformat}
> -------------------------------------------------------------------------------
> Test set: org.apache.hadoop.hdfs.TestDfsOverAvroRpc
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.486 sec <<<
> FAILURE!
> testWorkingDirectory(org.apache.hadoop.hdfs.TestDfsOverAvroRpc) Time
> elapsed: 1.424 sec <<< ERROR!
> org.apache.avro.AvroTypeException: Two methods with same name: delete
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
