[ https://issues.apache.org/jira/browse/HDDS-1262?focusedWorklogId=216535&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216535 ]
ASF GitHub Bot logged work on HDDS-1262: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Mar/19 23:45 Start Date: 20/Mar/19 23:45 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #626: HDDS-1262. In OM HA OpenKey call Should happen only leader OM. URL: https://github.com/apache/hadoop/pull/626#issuecomment-475070390 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 23 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 9 | Maven dependency ordering for branch | | +1 | mvninstall | 958 | trunk passed | | +1 | compile | 90 | trunk passed | | +1 | checkstyle | 24 | trunk passed | | -1 | mvnsite | 23 | ozone-manager in trunk failed. | | +1 | shadedclient | 719 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 20 | ozone-manager in trunk failed. | | +1 | javadoc | 64 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 11 | Maven dependency ordering for patch | | +1 | mvninstall | 89 | the patch passed | | +1 | compile | 86 | the patch passed | | +1 | cc | 86 | the patch passed | | +1 | javac | 86 | the patch passed | | +1 | checkstyle | 21 | the patch passed | | +1 | mvnsite | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 689 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 102 | the patch passed | | +1 | javadoc | 62 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 33 | common in the patch passed. | | -1 | unit | 38 | ozone-manager in the patch failed. | | -1 | unit | 663 | integration-test in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 3985 | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.ozone.om.ratis.TestOzoneManagerStateMachine | | | hadoop.ozone.client.rpc.TestBCSID | | | hadoop.ozone.om.TestOzoneManager | | | hadoop.ozone.client.rpc.TestFailureHandlingByClient | | | hadoop.ozone.client.rpc.TestContainerStateMachineFailures | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-626/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/626 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc | | uname | Linux 5ca5c06a1bcc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / f2b862c | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-626/3/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-626/3/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-626/3/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-626/3/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-626/3/testReport/ | | Max. process+thread count | 4014 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-626/3/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 216535) Time Spent: 1h 10m (was: 1h) > In OM HA OpenKey call Should happen only leader OM > -------------------------------------------------- > > Key: HDDS-1262 > URL: https://issues.apache.org/jira/browse/HDDS-1262 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Bharat Viswanadham > Assignee: Bharat Viswanadham > Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > In OM HA, currently, when openKey is called, in applyTransaction() on all OM > nodes, we make a call to SCM and write the allocateBlock information into OM > DB and also clientID will be generated by each OM node. > > The proposed approach is: > 1. In startTransaction, call openKey and the response returned should be used > to create a new OmRequest object and used in setting the transaction context. > And also modify the ozoneManager and KeymanagerImpl to handle the code with > and without ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org