[
https://issues.apache.org/jira/browse/HDDS-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799527#comment-16799527
]
Yiqun Lin commented on HDDS-1234:
---------------------------------
Hi [~avijayan],
{quote}On first glance, I am not able to understand the issue you mentioned in
TestContainerDBServiceProviderImpl. The expected and actual value seem to be
correct. I will check.
{quote}
Actually I mean to update {{ assertEquals(keyPrefixesForContainer.size(), 4);}}
to {{ assertEquals(4, keyPrefixesForContainer.size());}}. I remember that the
first paramter of {{assertEquals}} is the expected value not actul value.
{quote}Also, for the issue in ContainerKeyService, I used the direct
getTable().get(key) since we support only full keys now. It may be costly to
use iterator until we move to actual key prefix.
{quote}
Okay, would you mind adding a comment mention that only full keys are supported
for the time being in this line. Also null check for om keyinfo is still needed.
Hope now all review comments are clear, :).
> Iterate the OM DB snapshot and populate the recon container DB.
> ----------------------------------------------------------------
>
> Key: HDDS-1234
> URL: https://issues.apache.org/jira/browse/HDDS-1234
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
> Reporter: Aravindan Vijayan
> Assignee: Aravindan Vijayan
> Priority: Major
> Fix For: 0.5.0
>
> Attachments: HDDS-1234-000.patch, HDDS-1234-001.patch,
> HDDS-1234-002.patch, HDDS-1234-003.patch, HDDS-1234-004.patch
>
>
> * OM DB snapshot contains the Key->ContainerId + BlockId information.
> * Iterate the OM snapshot DB and create the reverse map of (ContainerId, Key
> prefix) -> Key count to be stored in the Recon container DB.
> * Use a codec to store data into Recon container DB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
