[ https://issues.apache.org/jira/browse/HDFS-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803438#comment-16803438 ]
Shweta commented on HDFS-14371: ------------------------------- Thanks [~smeng] for the review. Yes, agreed metaSaveAsString() would lead to an overhead. Uploaded patch v002. Please review. > Improve Logging in FSNamesystem by adding parameterized logging > --------------------------------------------------------------- > > Key: HDFS-14371 > URL: https://issues.apache.org/jira/browse/HDFS-14371 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Affects Versions: 3.3.0 > Reporter: Shweta > Assignee: Shweta > Priority: Minor > Attachments: HDFS-14371.001.patch, HDFS-14371.002.patch > > > Remove several instances of check for debug log enabled in FSNamesystem one > such example is as: > {code} > if (LOG.isDebugEnabled()) { > LOG.debug("list corrupt file blocks returned: " + count); > } > {code} > This can be replaced by using parameterized logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org