[ https://issues.apache.org/jira/browse/HDFS-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118088#comment-13118088 ]
Ivan Kelly commented on HDFS-2188: ---------------------------------- Uploaded new patch, rebased on trunk (over HDFS-2158). I've left in the old constructor now, it's @VisibleForTesting. I didn't changes the FileJournalManager constructor. This would be better done later i think, once HDFS-2174 is done. We shouldn't move attemptRestoreRemovedStorage into FileJournalManager at this point, as it would mean that it could get called multiple times if there are multiple FileJournalManagers. > HDFS-1580: Make FSEditLog create its journals from a list of URIs rather than > NNStorage > --------------------------------------------------------------------------------------- > > Key: HDFS-2188 > URL: https://issues.apache.org/jira/browse/HDFS-2188 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Ivan Kelly > Assignee: Ivan Kelly > Fix For: 0.23.0 > > Attachments: HDFS-2188.diff, HDFS-2188.diff, HDFS-2188.diff, > HDFS-2188.diff, HDFS-2188.diff > > > Currently, FSEditLog retrieves the list of Journals to create from NNStorage. > Obviously this is file specific. This JIRA aims to remove this restriction to > make it possible to create journals of custom types. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira