[ https://issues.apache.org/jira/browse/HDFS-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807967#comment-16807967 ]
Íñigo Goiri commented on HDFS-14400: ------------------------------------ [~kpalanisamy], my whole point is that I think that the counter is correct. This metrics represents the number of times we got an expired heartbeat. Here you are adding a new metric which is the current number of DNs that have a expired HB. We should keep the old one. > Namenode ExpiredHeartbeats metric > --------------------------------- > > Key: HDFS-14400 > URL: https://issues.apache.org/jira/browse/HDFS-14400 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 3.1.2 > Reporter: Karthik Palanisamy > Assignee: Karthik Palanisamy > Priority: Minor > Attachments: HDFS-14400-001.patch, HDFS-14400-002.patch, > HDFS-14400-003.patch > > > Noticed incorrect value in ExpiredHeartbeats metrics under namenode JMX. > We will increment ExpiredHeartbeats count when Datanode is dead but somehow > we missed to decrement when datanode is alive back. > {code} > { "name" : "Hadoop:service=NameNode,name=FSNamesystem", "modelerType" : > "FSNamesystem", "tag.Context" : "dfs", "tag.TotalSyncTimes" : "7 ", > "tag.HAState" : "active", ... "ExpiredHeartbeats" : 2, ... } > {code} > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org