[
https://issues.apache.org/jira/browse/HDDS-1379?focusedWorklogId=222606&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222606
]
ASF GitHub Bot logged work on HDDS-1379:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/19 20:30
Start Date: 03/Apr/19 20:30
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #689: HDDS-1379.
Convert all OM Volume related operations to HA model.
URL: https://github.com/apache/hadoop/pull/689#issuecomment-479647097
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 26 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 63 | Maven dependency ordering for branch |
| +1 | mvninstall | 1034 | trunk passed |
| +1 | compile | 98 | trunk passed |
| +1 | checkstyle | 26 | trunk passed |
| +1 | mvnsite | 97 | trunk passed |
| +1 | shadedclient | 750 | branch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| +1 | findbugs | 93 | trunk passed |
| +1 | javadoc | 68 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 10 | Maven dependency ordering for patch |
| +1 | mvninstall | 97 | the patch passed |
| +1 | compile | 88 | the patch passed |
| +1 | cc | 88 | the patch passed |
| +1 | javac | 88 | the patch passed |
| -0 | checkstyle | 22 | hadoop-ozone: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| +1 | mvnsite | 79 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 706 | patch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| -1 | findbugs | 50 | hadoop-ozone/ozone-manager generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| -1 | javadoc | 35 | hadoop-ozone_common generated 1 new + 1 unchanged - 0
fixed = 2 total (was 1) |
||| _ Other Tests _ |
| +1 | unit | 36 | common in the patch passed. |
| +1 | unit | 42 | ozone-manager in the patch passed. |
| -1 | unit | 784 | integration-test in the patch failed. |
| +1 | asflicense | 34 | The patch does not generate ASF License warnings. |
| | | 4380 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-ozone/ozone-manager |
| | Dead store to volume in
org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.handleSetVolumePropertyApply(OzoneManagerProtocolProtos$OMRequest)
At
OzoneManagerRequestHandler.java:org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.handleSetVolumePropertyApply(OzoneManagerProtocolProtos$OMRequest)
At OzoneManagerRequestHandler.java:[line 512] |
| | new org.apache.hadoop.ozone.om.exceptions.OMException(String,
OMException$ResultCodes) not thrown in
org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.handleStartTransaction(OzoneManagerProtocolProtos$OMRequest)
At OzoneManagerRequestHandler.java:in
org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.handleStartTransaction(OzoneManagerProtocolProtos$OMRequest)
At OzoneManagerRequestHandler.java:[line 386] |
| Failed junit tests | hadoop.ozone.om.TestOmMetrics |
| | hadoop.ozone.scm.pipeline.TestPipelineManagerMXBean |
| | hadoop.ozone.TestMiniChaosOzoneCluster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-689/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/689 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle cc |
| uname | Linux 2fe446930f83 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / d797907 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-689/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-689/1/artifact/out/new-findbugs-hadoop-ozone_ozone-manager.html
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-689/1/artifact/out/diff-javadoc-javadoc-hadoop-ozone_common.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-689/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-689/1/testReport/ |
| Max. process+thread count | 3800 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager
hadoop-ozone/integration-test U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-689/1/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 222606)
Time Spent: 40m (was: 0.5h)
> Convert all OM Volume related operations to HA model
> ----------------------------------------------------
>
> Key: HDDS-1379
> URL: https://issues.apache.org/jira/browse/HDDS-1379
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In this jira, we shall convert all OM related operations to OM HA model,
> which is a 2 step.
> # StartTransaction, where we validate request and check for any errors and
> return the response.
> # ApplyTransaction, where original OM request will have a response which
> needs to be applied to OM DB. This step is just to apply response to Om DB.
> In this way, all requests which are failed with like volume not found or some
> conditions which i have not satisfied like when deleting volume should be
> empty, these all will be executed during startTransaction, and if it fails
> these requests will not be written to raft log also.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
