[ https://issues.apache.org/jira/browse/HDFS-14403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812567#comment-16812567 ]
Erik Krogen commented on HDFS-14403: ------------------------------------ Hey [~linyiqun], regarding: {quote} Can we refactor LockCostProvider into COMMON not in HDFS module? Based on the current approach, we maintain a new mapping in FSN lock but it's actual used by FCQ not for HDFS itself. I mean for HDFS, it can do more easier, pass the rpc lock time into FCQ. Then FCQ implement plugin cost provider. Isn't this a better way? {quote} I'm not too sure about this. Would your proposal be that {{LockCostProvider}} lives within common, and exposes methods like {{incrementUserReadHoldTime}} and {{incrementUserWriteHoldTime}}, which would be called by {{FSNamesystemLock}}? The only advantage I see to this is that the logic becomes re-usable by other modules, but the idea that the cost of an operation is equal to its lock hold time is HDFS-specific, so it seems to me that it makes more sense to keep this isolated within the HDFS module. Please let me know if I misunderstood you or if you disagree. > Cost-Based RPC FairCallQueue > ---------------------------- > > Key: HDFS-14403 > URL: https://issues.apache.org/jira/browse/HDFS-14403 > Project: Hadoop HDFS > Issue Type: Improvement > Components: ipc, namenode > Reporter: Erik Krogen > Assignee: Christopher Gregorian > Priority: Major > Labels: qos, rpc > Attachments: CostBasedFairCallQueueDesign_v0.pdf, HDFS-14403.001.patch > > > HADOOP-15016 initially described extensions to the Hadoop FairCallQueue > encompassing both cost-based analysis of incoming RPCs, as well as support > for reservations of RPC capacity for system/platform users. This JIRA intends > to track the former, as HADOOP-15016 was repurposed to more specifically > focus on the reservation portion of the work. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org