[
https://issues.apache.org/jira/browse/HDFS-14418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812663#comment-16812663
]
Ayush Saxena commented on HDFS-14418:
-------------------------------------
Thanx [~elgoiri] for the comment.
I think technically with removal of redundant super user privileged check,
there is no functionality change, that will any how check the permission as it
was earlier, In case of failure, it would fail at first only and in the correct
case it was checking twice.Now that will check only once. I guess that won't
have any functionality impact. I am pretty sure that was for no good. And no
clue how that got it.That is just 2-3 lines below. So we aren't changing any
behavior, that should be fine I guess!!!
That only hampered the performance.Isn't doing any good.User can't change in 2
lines.
Regarding the redundant write lock, there is checking before taking write lock
and even after, and this behavior is at a lot of places (I guess all EC
commands too). Might be to ensure even after taking write lock, The operation
is supported.
Pls Review!!!!
> Remove redundant super user priveledge checks from namenode.
> ------------------------------------------------------------
>
> Key: HDFS-14418
> URL: https://issues.apache.org/jira/browse/HDFS-14418
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-14418-01.patch
>
>
> There are couple of methods that unnecessarily double checks super user
> privileged at namenode, which can reduced to single.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
