[
https://issues.apache.org/jira/browse/HDDS-1371?focusedWorklogId=225326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-225326
]
ASF GitHub Bot logged work on HDDS-1371:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/19 23:02
Start Date: 09/Apr/19 23:02
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #703: HDDS-1371.
Download RocksDB checkpoint from OM Leader to Follower.
URL: https://github.com/apache/hadoop/pull/703#discussion_r273736701
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -526,6 +530,48 @@ private void setOMNodeDetails(String serviceId, String
nodeId,
// Set this nodes OZONE_OM_ADDRESS_KEY to the discovered address.
configuration.set(OZONE_OM_ADDRESS_KEY,
NetUtils.getHostPortString(rpcAddress));
+
+ // Find the Ratis storage dir
+ String omRatisDirectory = OmUtils.getOMRatisDirectory(configuration);
+ if (omRatisDirectory == null || omRatisDirectory.isEmpty()) {
+ throw new IllegalArgumentException(HddsConfigKeys.OZONE_METADATA_DIRS +
+ " must be defined.");
+ }
+
+ omRatisStorageDir = OmUtils.createOMDir(omRatisDirectory);
+ omRatisSnapshotDir = OmUtils.createOMDir(
+ OmUtils.getOMRatisSnapshotDirectory(configuration));
+
+ // Get and set Http(s) address of local node. If base config keys are
+ // not set, check for keys suffixed with OM Node ID.
+ setOMNodeSpecificConfigs(nodeId);
+ }
+
+ /**
+ * Check if any of the following configuration keys have been set using OM
+ * Node ID suffixed to the key. If yes, then set the base key with the
+ * configured valued.
+ * 1. {@link OMConfigKeys#OZONE_OM_HTTP_ADDRESS_KEY}
+ * 2. {@link OMConfigKeys#OZONE_OM_HTTPS_ADDRESS_KEY}
+ * 3. {@link OMConfigKeys#OZONE_OM_HTTP_BIND_HOST_KEY}
+ * 4. {@link OMConfigKeys#OZONE_OM_HTTPS_BIND_HOST_KEY}
+ */
+ private void setOMNodeSpecificConfigs(String omNodeId) {
Review comment:
I didn't understand this. Could you explain a bit what it does?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 225326)
Time Spent: 1h 10m (was: 1h)
> Download RocksDB checkpoint from OM Leader to Follower
> ------------------------------------------------------
>
> Key: HDDS-1371
> URL: https://issues.apache.org/jira/browse/HDDS-1371
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> If a follower OM is lagging way behind the leader OM or in case of a restart
> or bootstrapping, a follower OM might need RocksDB checkpoint from the leader
> to catch up with it. This is because the leader might have purged its logs
> after taking a snapshot.
> This Jira aims to add support to download a RocksDB checkpoint from leader
> OM to follower OM through a HTTP servlet. We reuse the DBCheckpoint servlet
> used by Recon server.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
