[ 
https://issues.apache.org/jira/browse/HDDS-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814756#comment-16814756
 ] 

Jitendra Nath Pandey commented on HDDS-1294:
--------------------------------------------

# 
{quote}DistributedStorageHandler is a long lived object. The exclude list from 
this will never get cleaned up.
{quote}
The storage handler is closed only when {{OzoneHddsDatanodeService}} is 
stopped, therefore the problem is slowly all datanodes in the cluster may get 
added in the exclude list, and after that this datanode will not be able to 
serve any request. The exclusion should be in the context of a single session 
or should decay out.

 # It is odd that get methods are synchronized on the list objects, while add 
methods are synchronized on the class instance. Therefore, it is possible that 
a get will be executed while the list is being modified causing 
concurrent-modification exception. It is ok to synchronize the get methods on 
the class instance as well.

> ExcludeList shoud be a RPC Client config so that multiple streams can avoid 
> the same error.
> -------------------------------------------------------------------------------------------
>
>                 Key: HDDS-1294
>                 URL: https://issues.apache.org/jira/browse/HDDS-1294
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Client
>    Affects Versions: 0.4.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Shashikant Banerjee
>            Priority: Major
>              Labels: MiniOzoneChaosCluster
>         Attachments: HDDS-1294.000.patch, HDDS-1294.001.patch, 
> HDDS-1294.002.patch
>
>
> ExcludeList right now is a per BlockOutPutStream value, this can result in 
> multiple keys created out of the same client to run into same exception



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to